feat: Filter out unused irfo permit types from dropdown #190
Conversation
| /** | ||
| * Filter unused IDs out of the array for display (cant remove from DB as 100s of permit records still reference the ID, but not needed for new permits) | ||
| * | ||
| * @param array $data Data | ||
| * | ||
| * @return array | ||
| */ | ||
| public function filterArrayById(array $data): array | ||
| { | ||
| return array_filter($data, fn($record) => !in_array($record['id'], self::UNUSED_TYPE_IDS)); | ||
| } |
There was a problem hiding this comment.
Would this functionality be more appropriate as a database column we filter on? A soft delete of sorts that controls visibility?
There was a problem hiding this comment.
That was one approach i considered. Making schema changes, probably a new Repository method, changes to the query handler to call that method etc seemed like more to un-pick when the dependent permit records are finally deleted and this isnt needed anymore. Happy to re-factor in that pattern if you think its worthwhile though.
There was a problem hiding this comment.
I'd say let's refactor to make it easier for us in the future. Decoupling the application from the data is also a positive.
As these agreements usually have a date associated with them, I'd recommend instead of a boolean of "hidden", let's throw a (nullable) date in there instead. Then in the code, if the row has a date populated do a comparison with today. This will enable us to hide these rows on a particular date (expiration of an agreement - which can be done on creation - then we'd not need this type of ticket at all).
There was a problem hiding this comment.
No problem ill make the updates. 👍
Description
Filter out unused IRFO Permit types from drop down
Related issue: VOL5009
Before submitting (or marking as "ready for review")