Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: fix error on EBSR pages #47

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: fix error on EBSR pages #47

merged 2 commits into from
Feb 2, 2024

Conversation

JoshuaLicense
Copy link
Contributor

Description

Two issues:

  • invalid reference to unknown constant.
  • view path changed to relative path instead of the incorrect absolute route.

Related issue: https://dvsa.atlassian.net/browse/VOL-4904

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Feb 2, 2024
@fibble fibble merged commit bfa48d3 into main Feb 2, 2024
3 of 6 checks passed
@fibble fibble deleted the fix-ebsr-page branch February 2, 2024 11:08
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Open
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@JoshuaLicense
fix: fix error on EBSR pages (dvsa/olcs-selfserve#47)
a17c5bf 
* fix: fix invalid constant reference

* fix: fix invalid partial view path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fibble fibble fibble approved these changes

Assignees

@JoshuaLicense JoshuaLicense

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaLicense @fibble