Skip to content

Commit

Permalink
fix: fix error on EBSR pages (dvsa/olcs-selfserve#47)
Browse files Browse the repository at this point in the history
* fix: fix invalid constant reference

* fix: fix invalid partial view path
  • Loading branch information
JoshuaLicense authored Feb 2, 2024
1 parent ead904e commit a17c5bf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
'formatter' => function ($row) {
// DateTime formatter require data set at root of array
if (isset($row['busReg']['ebsrSubmissions'][0]['submittedDate'])) {
return date(\DATETIME_FORMAT, strtotime($row['busReg']['ebsrSubmissions'][0]['submittedDate']));
return date(Common\Module::$dateTimeFormat, strtotime($row['busReg']['ebsrSubmissions'][0]['submittedDate']));
}

return '';
Expand Down
10 changes: 5 additions & 5 deletions app/selfserve/module/Olcs/view/olcs/ebsr/uploads/detail.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
);

if ($ebsrSubmission['isBeingProcessed']) {
$childView = 'olcs/uploads/partial/detail-processing';
$childView = './partial/detail-processing';
} elseif ($ebsrSubmission['isFailure']) {
$childView = 'olcs/uploads/partial/detail-failed';
$childView = './partial/detail-failed';
} elseif ($ebsrSubmission['isSuccess']) {
$childView = 'olcs/uploads/partial/detail-success';
$childView = './partial/detail-success';
} else {
echo'There is no additional information for this file'; //very basic handling of legacy until data is cleansed
return;
Expand All @@ -26,11 +26,11 @@
]
);
?>

<div class="row">
<div class="two-thirds">
<?php echo $this->render($childView, ['documentUrl' => $documentUrl, 'ebsrSubmission' => $ebsrSubmission]); ?>
</div>
</div>

</div>
</div>

0 comments on commit a17c5bf

Please sign in to comment.