Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: Not able to surrender a psv licence #111

Merged
merged 3 commits into from
Apr 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions module/Olcs/src/Controller/Licence/Surrender/StartController.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Laminas\Http\Response;
use Laminas\I18n\Translator\Translator;
use Laminas\Mvc\MvcEvent;
use Laminas\View\Model\ViewModel;
use Olcs\Controller\AbstractSelfserveController;
use Olcs\Controller\Config\DataSource\DataSourceConfig;
use Permits\Controller\Config\FeatureToggle\FeatureToggleConfig;
Expand Down Expand Up @@ -68,7 +69,7 @@ public function onDispatch(MvcEvent $e)
/**
* IndexAction
*
* @return array|\Laminas\View\Model\ViewModel
* @return array|ViewModel
*/
public function indexAction()
{
Expand Down Expand Up @@ -126,23 +127,15 @@ private function getGvData(): array
*
* @psalm-return array{pageTitle: 'licence.surrender.start.title.psv', cancelBus: list{mixed}}
*/
private function getPsvData(Translator $translateService): array
private function getPsvData(TranslationHelperService $translateService): array
{
return [
'pageTitle' => 'licence.surrender.start.title.psv',
'cancelBus' => [$translateService->translate('licence.surrender.start.cancel.bus')]
];
}

/**
* getView
*
* @param array $licence
* @param Translator $translateService
*
* @return \Laminas\View\Model\ViewModel
*/
private function getView($licence, $translateService): \Laminas\View\Model\ViewModel
private function getView(array $licence, TranslationHelperService $translateService): ViewModel
{
$view = $this->genericView();

Expand Down
Loading