Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: OLCS composer packages to dev-project/messaging #19

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: OLCS composer packages to dev-project/messaging #19

merged 1 commit into from
Jan 18, 2024

Conversation

wadedvsa
Copy link
Contributor

Description

Switch composer OLCS packages to dev-project/messages

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@wadedvsa wadedvsa changed the base branch from main to project/messaging January 18, 2024 14:36
@wadedvsa wadedvsa merged commit dc84af8 into project/messaging Jan 18, 2024
3 of 6 checks passed
@wadedvsa wadedvsa deleted the feature/composer-olcs-dev-project-messaging branch January 18, 2024 14:44
jerotire added a commit that referenced this pull request Feb 16, 2024
@jerotire @wadedvsa @hobbyhacker0
feat: Merge project/messaging (#59)
4781f02 
* feat: OLCS composer packages to dev-project/messaging (#19)

* feat: Messaging conversation list (#22)

* feat: Messaging conversation list

* fix: Missing route from branch re-create

* fix: Rename messages to conversations

* fix: Unused null check

* feat: Update olcs-comon lock

* feat: List messages in a conversation. (#23)

* feat: Conversation messages list

* feat: Controller view test

* fix: Unused null check

* fix: Test PR changes (case and unused var)

* fix: Just added whitespace!

* feat: Messaging tab visibility (#32)

* Update README.md

* WIP

* Tab WIP

* Messaging tab view based on feature toggle only

* Messaging tab logic without extra query

* Change routing to conversations

* Clean unused

* Review improvement

* Revert whitespace from bad resolution

---------

Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>

* feat: Project branch change for composer.lock

* feat: Composer update due to common and transfer merges from main

* fix: Navigation unit test (#36)

* Add messaging feature in NavigationTest

* fix: Add once() assertions to shouldReceive()

* Fix test to match CI error_reporting

* Formatting improvements

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Message list split in to two columns (#41)

* feat: Message list split in to two columns

* feat: composer.lock

* feat: Start conversation link (#45)

* feat: Start a new conversation link (and empty page)

* fix: PR: Rename newAction to addAction

* feat: Add header to new sidebar for start link (#50)

* feat: Reply to conversation (#49)

* feat: Reply to a conversation

* fix: Strong types on form

* feat: Messsaging new conversation form (#53)

* chore: so far

* chore: so far

* chore: so far

* olcs-transfer bump

* feat: use GOVUK-SELECT class

* chore: code clean-up

* bump: olcs-common

* chore: bump olcs-common and olcs-transfer

* Add "Messaging not disabled" to tab display conditions (#57)

* Add condition for messaging disabled for organisation

* Adjust to match call count

* Add full return to tests

* Whitespace

---------

Co-authored-by: Saul Wilcox <[email protected]>

* fix: Trying to access array key on null in navigation (#60)

* fix: swapped container interface interop for Psr (#62)

* chore: form annotation changes (#63)

* chore: revert composer.json/lock to use non-messaging project branches (#64)

---------

Co-authored-by: Wade Womersley <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
wadedvsa added a commit that referenced this pull request Feb 19, 2024
@wadedvsa @hobbyhacker0 @jerotire
fix: Disable reply on closed conversations (#61)
49b2cdc 
* feat: OLCS composer packages to dev-project/messaging (#19)

* feat: Messaging conversation list (#22)

* feat: Messaging conversation list

* fix: Missing route from branch re-create

* fix: Rename messages to conversations

* fix: Unused null check

* feat: Update olcs-comon lock

* feat: List messages in a conversation. (#23)

* feat: Conversation messages list

* feat: Controller view test

* fix: Unused null check

* fix: Test PR changes (case and unused var)

* fix: Just added whitespace!

* feat: Messaging tab visibility (#32)

* Update README.md

* WIP

* Tab WIP

* Messaging tab view based on feature toggle only

* Messaging tab logic without extra query

* Change routing to conversations

* Clean unused

* Review improvement

* Revert whitespace from bad resolution

---------

Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>

* feat: Project branch change for composer.lock

* feat: Composer update due to common and transfer merges from main

* fix: Navigation unit test (#36)

* Add messaging feature in NavigationTest

* fix: Add once() assertions to shouldReceive()

* Fix test to match CI error_reporting

* Formatting improvements

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Message list split in to two columns (#41)

* feat: Message list split in to two columns

* feat: composer.lock

* feat: Start conversation link (#45)

* feat: Start a new conversation link (and empty page)

* fix: PR: Rename newAction to addAction

* feat: Add header to new sidebar for start link (#50)

* feat: Reply to conversation (#49)

* feat: Reply to a conversation

* fix: Strong types on form

* feat: Messsaging new conversation form (#53)

* chore: so far

* chore: so far

* chore: so far

* olcs-transfer bump

* feat: use GOVUK-SELECT class

* chore: code clean-up

* bump: olcs-common

* chore: bump olcs-common and olcs-transfer

* Add "Messaging not disabled" to tab display conditions (#57)

* Add condition for messaging disabled for organisation

* Adjust to match call count

* Add full return to tests

* Whitespace

---------

Co-authored-by: Saul Wilcox <[email protected]>

* fix: Trying to access array key on null in navigation (#60)

* fix: Disable reply on closed conversations

* fix: Test fix

* fix: Pull composer.json from main

---------

Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: James Wragg <[email protected]>
jerotire added a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@jerotire @wadedvsa @hobbyhacker0
feat: Merge project/messaging (dvsa/olcs-selfserve#59)
e0924c6 
* feat: OLCS composer packages to dev-project/messaging (dvsa/olcs-selfserve#19)

* feat: Messaging conversation list (dvsa/olcs-selfserve#22)

* feat: Messaging conversation list

* fix: Missing route from branch re-create

* fix: Rename messages to conversations

* fix: Unused null check

* feat: Update olcs-comon lock

* feat: List messages in a conversation. (dvsa/olcs-selfserve#23)

* feat: Conversation messages list

* feat: Controller view test

* fix: Unused null check

* fix: Test PR changes (case and unused var)

* fix: Just added whitespace!

* feat: Messaging tab visibility (dvsa/olcs-selfserve#32)

* Update README.md

* WIP

* Tab WIP

* Messaging tab view based on feature toggle only

* Messaging tab logic without extra query

* Change routing to conversations

* Clean unused

* Review improvement

* Revert whitespace from bad resolution

---------

Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>

* feat: Project branch change for composer.lock

* feat: Composer update due to common and transfer merges from main

* fix: Navigation unit test (dvsa/olcs-selfserve#36)

* Add messaging feature in NavigationTest

* fix: Add once() assertions to shouldReceive()

* Fix test to match CI error_reporting

* Formatting improvements

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Message list split in to two columns (dvsa/olcs-selfserve#41)

* feat: Message list split in to two columns

* feat: composer.lock

* feat: Start conversation link (dvsa/olcs-selfserve#45)

* feat: Start a new conversation link (and empty page)

* fix: PR: Rename newAction to addAction

* feat: Add header to new sidebar for start link (dvsa/olcs-selfserve#50)

* feat: Reply to conversation (dvsa/olcs-selfserve#49)

* feat: Reply to a conversation

* fix: Strong types on form

* feat: Messsaging new conversation form (dvsa/olcs-selfserve#53)

* chore: so far

* chore: so far

* chore: so far

* olcs-transfer bump

* feat: use GOVUK-SELECT class

* chore: code clean-up

* bump: olcs-common

* chore: bump olcs-common and olcs-transfer

* Add "Messaging not disabled" to tab display conditions (dvsa/olcs-selfserve#57)

* Add condition for messaging disabled for organisation

* Adjust to match call count

* Add full return to tests

* Whitespace

---------

Co-authored-by: Saul Wilcox <[email protected]>

* fix: Trying to access array key on null in navigation (dvsa/olcs-selfserve#60)

* fix: swapped container interface interop for Psr (dvsa/olcs-selfserve#62)

* chore: form annotation changes (dvsa/olcs-selfserve#63)

* chore: revert composer.json/lock to use non-messaging project branches (dvsa/olcs-selfserve#64)

---------

Co-authored-by: Wade Womersley <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
jerotire added a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@wadedvsa @hobbyhacker0 @jerotire
fix: Disable reply on closed conversations (dvsa/olcs-selfserve#61)
e47e8ec 
* feat: OLCS composer packages to dev-project/messaging (dvsa/olcs-selfserve#19)

* feat: Messaging conversation list (dvsa/olcs-selfserve#22)

* feat: Messaging conversation list

* fix: Missing route from branch re-create

* fix: Rename messages to conversations

* fix: Unused null check

* feat: Update olcs-comon lock

* feat: List messages in a conversation. (dvsa/olcs-selfserve#23)

* feat: Conversation messages list

* feat: Controller view test

* fix: Unused null check

* fix: Test PR changes (case and unused var)

* fix: Just added whitespace!

* feat: Messaging tab visibility (dvsa/olcs-selfserve#32)

* Update README.md

* WIP

* Tab WIP

* Messaging tab view based on feature toggle only

* Messaging tab logic without extra query

* Change routing to conversations

* Clean unused

* Review improvement

* Revert whitespace from bad resolution

---------

Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>

* feat: Project branch change for composer.lock

* feat: Composer update due to common and transfer merges from main

* fix: Navigation unit test (dvsa/olcs-selfserve#36)

* Add messaging feature in NavigationTest

* fix: Add once() assertions to shouldReceive()

* Fix test to match CI error_reporting

* Formatting improvements

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Message list split in to two columns (dvsa/olcs-selfserve#41)

* feat: Message list split in to two columns

* feat: composer.lock

* feat: Start conversation link (dvsa/olcs-selfserve#45)

* feat: Start a new conversation link (and empty page)

* fix: PR: Rename newAction to addAction

* feat: Add header to new sidebar for start link (dvsa/olcs-selfserve#50)

* feat: Reply to conversation (dvsa/olcs-selfserve#49)

* feat: Reply to a conversation

* fix: Strong types on form

* feat: Messsaging new conversation form (dvsa/olcs-selfserve#53)

* chore: so far

* chore: so far

* chore: so far

* olcs-transfer bump

* feat: use GOVUK-SELECT class

* chore: code clean-up

* bump: olcs-common

* chore: bump olcs-common and olcs-transfer

* Add "Messaging not disabled" to tab display conditions (dvsa/olcs-selfserve#57)

* Add condition for messaging disabled for organisation

* Adjust to match call count

* Add full return to tests

* Whitespace

---------

Co-authored-by: Saul Wilcox <[email protected]>

* fix: Trying to access array key on null in navigation (dvsa/olcs-selfserve#60)

* fix: Disable reply on closed conversations

* fix: Test fix

* fix: Pull composer.json from main

---------

Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: Joshua License <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: James Wragg <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hobbyhacker0 hobbyhacker0 hobbyhacker0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wadedvsa @hobbyhacker0