feat: Nicer error message on reply form with auto expand on error. (d…

…vsa/olcs-internal#103)
dvsa · Mar 5, 2024 · fa70b35 · fa70b35
1 parent b3cd448
commit fa70b35
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/internal/module/Olcs/src/Controller/Messages/AbstractConversationMessagesController.php b/app/internal/module/Olcs/src/Controller/Messages/AbstractConversationMessagesController.php
@@ -113,6 +113,7 @@ protected function parseReply(Form $form)
         $form->get('id')->setValue($this->params()->fromRoute('conversation'));
 
         if (!$form->isValid()) {
+            $this->placeholder()->setPlaceholder('open-reply', true);
             return parent::indexAction();
         }
 

diff --git a/app/internal/module/Olcs/src/Form/Model/Fieldset/LicenceMessageReply.php b/app/internal/module/Olcs/src/Form/Model/Fieldset/LicenceMessageReply.php
@@ -16,7 +16,10 @@ class LicenceMessageReply
      *     "class": "extra-long",
      *     "maxlength": 1000
      * })
-     * @Form\Options({"label": "You can enter up to 1000 characters"})
+     * @Form\Options({
+     *     "label": "You can enter up to 1000 characters",
+     *     "error-message": "Value is required and must be between 5 and 1000 characters."
+     * })
      * @Form\Required(true)
      * @Form\Type(\Laminas\Form\Element\Textarea::class)
      * @Form\Filter(\Laminas\Filter\StringTrim::class)

diff --git a/app/internal/module/Olcs/view/pages/conversation/messages.phtml b/app/internal/module/Olcs/view/pages/conversation/messages.phtml
@@ -14,7 +14,7 @@
 
 
 <?php if ($this->placeholder('can-reply')->getValue()): ?>
-  <details class="govuk-details" data-module="govuk-details">
+  <details class="govuk-details" data-module="govuk-details"<?php if ($this->placeholder('open-reply')->getValue()): ?> open<?php endif; ?>>
     <summary class="govuk-details__summary" aria-controls="details-content-operating-centre">
         <span class="govuk-details__summary-text">
             Send a reply