Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): vol5506 fix variables #168

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

cmarstondvsa
Copy link
Contributor

Description

Related issue: JIRA_TICKET_NUMBER

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

Copy link
Contributor

Terraform plan for environment: dev

Commit: ad10db0

API version: 988f85a
Selfserve version: 988f85a
Internal version: 988f85a

Plan summary

1 to add, 2 to change, 0 to destroy

🆕 Creates

module.service.module.batch.aws_batch_job_definition.this["process-queue"]

🔄 Updates

module.service.module.batch.aws_batch_job_queue.this["high_priority"]
module.service.module.batch.aws_batch_job_queue.this["low_priority"]

Show full plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.batch.aws_batch_job_definition.this["process-queue"] will be created
  + resource "aws_batch_job_definition" "this" {
      + arn                        = (known after apply)
      + arn_prefix                 = (known after apply)
      + container_properties       = jsonencode(
            {
              + command                      = [
                  + "/var/www/html/vendor/bin/laminas",
                  + "--container=/var/www/html/config/container-cli.php",
                  + "queue:process-queue",
                ]
              + executionRoleArn             = "arn:aws:iam::054614622558:role/vol-app-dev-api-service-20240418150301367500000003"
              + fargatePlatformConfiguration = {
                  + platformVersion = "LATEST"
                }
              + image                        = "054614622558.dkr.ecr.eu-west-1.amazonaws.com/vol-app/cli:latest"
              + logConfiguration             = {
                  + logDriver = "awslogs"
                  + options   = {
                      + awslogs-group         = "/aws/batch"
                      + awslogs-region        = "eu-west-1"
                      + awslogs-stream-prefix = "process-queue"
                    }
                }
              + resourceRequirements         = [
                  + {
                      + type  = "VCPU"
                      + value = "1"
                    },
                  + {
                      + type  = "MEMORY"
                      + value = "2048"
                    },
                ]
            }
        )
      + deregister_on_new_revision = true
      + id                         = (known after apply)
      + name                       = "process-queue"
      + platform_capabilities      = [
          + "FARGATE",
        ]
      + propagate_tags             = true
      + revision                   = (known after apply)
      + tags_all                   = {
          + "Environment" = "dev"
          + "Repository"  = "https://github.com/dvsa/vol-app"
        }
      + type                       = "container"

      + retry_strategy {
          + attempts = 1

          + evaluate_on_exit {
              + action       = "exit"
              + on_exit_code = "0"
            }
          + evaluate_on_exit {
              + action       = "retry"
              + on_exit_code = "1"
            }
        }

      + timeout {
          + attempt_duration_seconds = 60
        }
    }

  # module.service.module.batch.aws_batch_job_queue.this["high_priority"] will be updated in-place
  ~ resource "aws_batch_job_queue" "this" {
        id                    = "arn:aws:batch:eu-west-1:054614622558:job-queue/BatchTestHighPriorityFargate"
        name                  = "BatchTestHighPriorityFargate"
      + tags                  = {}
        # (6 unchanged attributes hidden)
    }

  # module.service.module.batch.aws_batch_job_queue.this["low_priority"] will be updated in-place
  ~ resource "aws_batch_job_queue" "this" {
        id                    = "arn:aws:batch:eu-west-1:054614622558:job-queue/BatchTestLowPriorityFargate"
        name                  = "BatchTestLowPriorityFargate"
      + tags                  = {}
        # (6 unchanged attributes hidden)
    }

Plan: 1 to add, 2 to change, 0 to destroy.

@JoshuaLicense JoshuaLicense merged commit e8c4935 into main Jul 12, 2024
15 checks passed
@JoshuaLicense JoshuaLicense deleted the vol5506-fix-batch-memory branch July 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants