-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(terraform): vol5223 give batch jobs a priority and share identifier #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan for environment:
|
Terraform plan for environment:
|
matbeales
changed the title
fix(terraform): VOL5223 give batch jobs a priority and share identifier
fix(terraform): vol5223 give batch jobs a priority and share identifier
Aug 8, 2024
cmarstondvsa
approved these changes
Aug 8, 2024
JoshuaLicense
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The queue has been set up with a fair share scheduling policy, so the batch jobs need a share identifier and priority to be submitted. I've set defaults for now but we can make them more specific further down the line.
Annoyingly there is an option to add a scheduling priority to a job definition in terraform, but this option does not yet exist in the batch module, so we need to set an override in the scheduling instead.
Related issue: https://dvsa.atlassian.net/browse/VOL-5223
Before submitting (or marking as "ready for review")