New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): create productionised application dockerfile #25

Merged

JoshuaLicense merged 51 commits into main from feat/VOL-4796

Apr 18, 2024

Contributor

rahul-dvsa commented Mar 5, 2024 •

edited

Loading

Description

Related issue: JIRA_TICKET_NUMBER

Before submitting (or marking as "ready for review")

Does the pull request title follow the conventional commit specification?
Have you performed a self-review of the code
Have you have added tests that prove the fix or feature is effective and working
Did you make sure to update any documentation relating to this change?

rahul-dvsa and others added 7 commits

February 27, 2024 09:17


          Initial draft of dockerfile

6b80068


          feat: initial code review internal AWS

2a08dc3


          adding code for php docker extentions configuration

4c07656


          installing extensions configuration

84a7f28


          updated dockerfile

0d144c0


          updated .gitignore

1616fde


          feature: internal code review and updates

2956cab

awshuss reviewed

View reviewed changes

app/api/.gitignore Outdated Show resolved Hide resolved

awshuss reviewed

View reviewed changes

app/api/10-opcache.ini Outdated Show resolved Hide resolved

awshuss reviewed

View reviewed changes

app/api/10-opcache.ini Outdated Show resolved Hide resolved

awshuss reviewed

View reviewed changes

app/api/10-opcache.ini Outdated Show resolved Hide resolved

awshuss reviewed

View reviewed changes

app/api/zzzz-www.conf Outdated Show resolved Hide resolved

awshuss reviewed

View reviewed changes

app/api/backend.conf Outdated Show resolved Hide resolved


          Implemented review comments

42d132d

rahul-dvsa marked this pull request as ready for review

March 5, 2024 16:14

rahul-dvsa added 3 commits

March 5, 2024 16:53


          Merge remote-tracking branch 'origin/main' into feat/VOL-4796, gettin…

d3bbc57

…g the latest directory changes from main


          Aligned to the directory

c4c79fd


          doc: comments updated

1d09e66

rahul-dvsa changed the title ~~Feat/vol 4796~~ feat(config): Create productionised application Dockerfile

rahul-dvsa changed the title ~~feat(config): Create productionised application Dockerfile~~ feat(config): create productionised application dockerfile

rahul-dvsa changed the title ~~feat(config): create productionised application dockerfile~~ feat(docker): create productionised application dockerfile


          opcache max value updated to 20000 based on total php files in project

rahul-dvsa requested review from sdh100shaun, JoshuaLicense, apaidipa and clorro

March 6, 2024 10:05

JoshuaLicense suggested changes

View reviewed changes

infra/docker/api/10-opcache.ini Outdated Show resolved Hide resolved

infra/docker/api/10-opcache.ini Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/backend.conf Outdated Show resolved Hide resolved

infra/docker/api/backend.conf Outdated Show resolved Hide resolved

infra/docker/api/zzzz-www.conf Outdated Show resolved Hide resolved

rahul-dvsa added 3 commits

March 7, 2024 16:15


          Feedback implemented

fd95ee3


          Updated nginx config with secure headers

c4c714c


          removed the overrides config from www.conf file

03e2b41

gabrielg2020 added 8 commits

April 17, 2024 12:20


          fix: fixed formatting in php.ini

ee00e3b


          fix: changed where artifact is downloaded

2392ddd


          feat: add application code to /var/www/html

3ae5307


          fix: need root access to change permissions to app code

359f2fa


          fix: changed nginx conf name to api & revert user back to www-data

ea0f194


          feat: configured nginx

ba70a97


          feat: add relevant api security configurations to nginx config

7d9a9a8


          chore: removed backend.conf

4d1046e

gabrielg2020 force-pushed the feat/VOL-4796 branch from 875bad3 to 4d1046e Compare

April 18, 2024 08:41


          fix: composer update in php.yaml

e39ef96

gabrielg2020 self-assigned this

JoshuaLicense suggested changes

View reviewed changes

.github/workflows/php.yaml Outdated Show resolved Hide resolved

infra/docker/api/api.conf Outdated Show resolved Hide resolved

gabrielg2020 added 3 commits

April 18, 2024 09:54


          fix: removing composer update to see inital error

9add96e


          refactor: fixed formatting in api.conf

c746137


          fix: added versions to apk ADD

33dcd5a

gabrielg2020 force-pushed the feat/VOL-4796 branch from f02f936 to 33dcd5a Compare

April 18, 2024 10:10

gabrielg2020 added 2 commits

April 18, 2024 11:59


          fix: fixed package version and added quotes

3f7f8ce


          fix: added double quotes across Dockerfile

9f4057f

clorro force-pushed the feat/VOL-4796 branch from e653126 to fe125f9 Compare

April 18, 2024 11:57

gabrielg2020 added 2 commits

April 18, 2024 13:37


          fix: different formatting to try and fix linting

cea8e35


          fix: added stable tag to image

1862d22

gabrielg2020 force-pushed the feat/VOL-4796 branch from 06e7ddb to 1862d22 Compare

April 18, 2024 13:25

JoshuaLicense reviewed

View reviewed changes

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

infra/docker/api/Dockerfile Outdated Show resolved Hide resolved

gabrielg2020 added 3 commits

April 18, 2024 14:34


          fix: less strict version pinning

48c5c51


          fix: ignore DL3018 & SC2086 linting errors

f0cc1fd


          Merge branch 'main' into feat/VOL-4796

JoshuaLicense approved these changes

View reviewed changes

JoshuaLicense merged commit 77ab726 into main

12 checks passed

JoshuaLicense deleted the feat/VOL-4796 branch

April 18, 2024 16:05

github-actions bot mentioned this pull request

chore(main): release 1.0.0 #20

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gabrielg2020 gabrielg2020 left review comments

awshuss awshuss left review comments

JoshuaLicense JoshuaLicense approved these changes

sdh100shaun Awaiting requested review from sdh100shaun

apaidipa Awaiting requested review from apaidipa

clorro Awaiting requested review from clorro

Labels

None yet