-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --no-interaction support to local refresh #266
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Few things, one really minor.
this.filesToCopy = files; | ||
this.filesToCopy = Array.from(appConfigDistFiles.keys()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break the interactive version. Let's move the non-interactive version conditional to early exit after we have a list of files.
Something like this?
// ...
for (const dir of phpAppDirectories) {
// ...
}
// ...
if (noInteraction) {
this.filesToCopy = Array.from(appConfigDistFiles.keys());
}
// ...
const { files } = await prompts({
// ...
});
// ...
Description
Adds support to local refresh for no interaction.
When using the flags
-i
or--no-interaction
this runs the local refresh in non-interactive mode; this will execute the following: composer install, copy app dist files (all), reset database, create liquibase.properties file, flush redis, and reset ldap.Before submitting (or marking as "ready for review")