Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(githooks): remove dataworks githook #107

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(githooks): remove dataworks githook #107

merged 2 commits into from
Oct 31, 2023

Conversation

alv-lop
Copy link
Member

@alv-lop alv-lop commented Oct 31, 2023 •
edited
Loading

  • Removes dataworks githook reference as this is not needed in this repo.
  • Temporarily disables any AWS job from the PR stage until a new set of keys are provided

@alv-lop
fix(githooks): remove dataworks githook
4f0cd24 
Signed-off-by: Alvaro Lopez Hernandez <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

kics-logo

KICS version: v1.5.15

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 12
TRACE TRACE 0
TOTAL TOTAL 13
Metric Values
Files scanned placeholder 21
Files parsed placeholder 21
Files failed to scan placeholder 0
Total executed queries placeholder 1036
Queries failed to execute placeholder 0
Execution time placeholder 29

@alv-lop
ci(pr): disable jobs that require AWS access until a valid set of key…
2988244 
…s are available as secrets

Signed-off-by: Alvaro Lopez Hernandez <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

KaramKapoor
KaramKapoor approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@KaramKapoor KaramKapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alv-lop alv-lop merged commit b0285f3 into main Oct 31, 2023
3 checks passed
@alv-lop alv-lop deleted the fix/githooks branch October 31, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaramKapoor KaramKapoor KaramKapoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alv-lop @KaramKapoor