Skip to content

Commit

Permalink
chore: Adding disclaimers and comments. #342
Browse files Browse the repository at this point in the history
  • Loading branch information
LuchoTurtle committed Oct 24, 2023
1 parent a9533cd commit b98ffa5
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/deploy_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
- name: 🐦 Install Flutter
uses: subosito/flutter-action@v2
with:
# If the flutter version that is used in development increases, it's recommended this one increases as well
flutter-version: "3.13.5"
channel: "stable"

Expand Down Expand Up @@ -74,7 +75,10 @@ jobs:
# MUST match the package name defined in `android/app/build.gradle`
packageName: com.dwyl.app

# Can be 'alpha'/'beta'/'internal'/'production'
# Can be 'alpha'/'beta'/'internal'/'production'.
# 'production' is relevant to the final stable version released to ALL clients
# 'internal' can be used for development versions and testing
# 'alpha' and 'beta' can be used for pre-release/staging purposes, with a smaller userbase
track: production

releaseFiles: ${{ github.workspace }}/build/app/outputs/bundle/release/app-release.aab
Expand Down
32 changes: 32 additions & 0 deletions deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,15 @@ Let's go through them right now.
##### Create app inside Google Play and set it up
> [!WARNING]
>
> When you create an app, it is permanent.
> Although you can [ask Google to delete it](https://stackoverflow.com/questions/14850708/delete-an-unpublished-app-from-google-play),
> it will only work if it doesn't have any installs.
>
> You can *unpublish* an application, but the package name is tied to it *forever*.
> Check https://stackoverflow.com/questions/34846872/how-to-unpublish-an-app-in-google-play-developer-console.
Firstly, you need to create an app project in your
`Google Play Console` account.
Expand Down Expand Up @@ -940,6 +949,29 @@ https://stackoverflow.com/questions/53570575/flutter-upgrade-the-version-code-fo
#### Implementing our workflow file
Now that everything is correctly set up,
we can start going over a simple workflow Github Action
that is suitable for the `main` (or `prod`) branch.
In this workflow, we will want to
**mainly create the app bundle and ship it to our published app**
on `Google Play Console`.
We'll create a new workflow
inside `.github/workflows`
and name it `deploy_android.yml`.
Because we're only interested in
deploying features merged into the `main` branch,
this workflow will solely be dedicated to it.
However,
as we've stated before,
you may
// TODO add workflow file here.
Expand Down

0 comments on commit b98ffa5

Please sign in to comment.