Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: request.auth.isAuthenticated is true and request.auth.credentials is {} when user not logged in #111

Closed
alanshaw opened this issue Oct 14, 2015 · 7 comments
Closed

Regression: request.auth.isAuthenticated is true and request.auth.credentials is {} when user not logged in #111

alanshaw opened this issue Oct 14, 2015 · 7 comments
Assignees
@alanshaw
Labels
bug help wanted priority-1

Comments

@alanshaw
Copy link
Member

With the latest version of the plugin my mode: 'try' routes exhibit this behaviour.

This did not happen previously.
@nelsonic
Copy link
Member

Thanks very much for reporting this @alanshaw can you give us a bit more detail as to the circumstance/context where this is happening in your app so we can create a regression test and fix this.

@alanshaw
Copy link
Member Author

I will submit a test when I get a sec...

@nelsonic
Copy link
Member

Sweet. thanks! 👍

@alanshaw
Copy link
Member Author

In the mean time I rolled back to v5.1.0

@nelsonic
Copy link
Member

Makes sense.
We really did not expect the update to introduce a "breaking"" change...
Thanks very much for reporting it!

@alanshaw
Copy link
Member Author

alanshaw@736067f

Both auth modes 'optional' and 'try' fail the test for isAuthenticated being false. Am I doing something wrong here?

@nelsonic
Copy link
Member

Good question @alanshaw . ❓
I'm busy investigating this now. ⌛

nelsonic added a commit that referenced this issue Oct 15, 2015
@nelsonic
testing try mode for: #111 currently failing!!
18ebe00
nelsonic added a commit that referenced this issue Oct 15, 2015
@nelsonic
remove check for auth mode. closes hapijs/hapi#2843 - see discussion: #…
c8506bf 
…111
@nelsonic nelsonic mentioned this issue Oct 15, 2015
Merged
ChALkeR added a commit to ChALkeR/retire.js that referenced this issue Mar 23, 2018
@ChALkeR
Fix hapi-auth-jwt2 affected range and summary
37c5bca 
atOrAbove was missing, the first (and only) affected version was 5.1.1
Also, the summary was incorrect.

Refs: https://nodesecurity.io/advisories/81
Refs: dwyl/hapi-auth-jwt2#111
@ChALkeR ChALkeR mentioned this issue Mar 23, 2018
Merged
eoftedal pushed a commit to RetireJS/retire.js that referenced this issue Mar 24, 2018
@ChALkeR @eoftedal
Fix hapi-auth-jwt2 affected range and summary (#212)
760d340 
atOrAbove was missing, the first (and only) affected version was 5.1.1
Also, the summary was incorrect.

Refs: https://nodesecurity.io/advisories/81
Refs: dwyl/hapi-auth-jwt2#111
AdamBarah added a commit to AdamBarah/retire.js that referenced this issue Jul 15, 2022
@AdamBarah @eoftedal
Fix hapi-auth-jwt2 affected range and summary (#212)
e63fd5f 
atOrAbove was missing, the first (and only) affected version was 5.1.1
Also, the summary was incorrect.

Refs: https://nodesecurity.io/advisories/81
Refs: dwyl/hapi-auth-jwt2#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanshaw alanshaw

Labels
bug help wanted priority-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanshaw @nelsonic