Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt label #101

Closed
3 tasks done
nelsonic opened this issue Jan 5, 2022 · 7 comments
Closed
3 tasks done

tech-debt label #101

nelsonic opened this issue Jan 5, 2022 · 7 comments
Assignees
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality priority-3 Third priority. Considered "Nice to Have". Not urgent.

Comments

@nelsonic
Copy link
Member

nelsonic commented Jan 5, 2022

Sadly, on reviewing (my own) code, it's become clear to me that we have incurred some technical debt.
So proposing that we create a tech-debt label

  • Label name: tech-debt
  • Description: "A feature/requirement implemented in a sub-optimal way & must be re-written."
  • Color: #FF3636 (a medium light shade of red) https://www.colorhexa.com/ff3636

Note: We have a decent summary of technical debt in: https://github.com/dwyl/product-owner-guide#what-is-technical-debt

This issue is just about adding the label to our central repository so that new projects get it.
Anyone have an objection to me creating this label and the corresponding PR to add the detail to the README.md?

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality discuss Share your constructive thoughts on how to make progress with this issue labels Jan 5, 2022
@iteles
Copy link
Member

iteles commented Jan 5, 2022

No objections to adding it.

Although choosing speed is the usual reason for tech debt, I've also seen it show up due to lack of experience or just laziness (choosing the easy way rather than specifically a fast way).
Is it worth changing the description to:

A feature/requirement is implemented in a sub-optimal way & must be re-written.

?

@nelsonic
Copy link
Member Author

nelsonic commented Jan 5, 2022

@iteles great points. How about:

"A feature/requirement implemented in a sub-optimal way & must be re-written." (removed the "is"...)

@iteles
Copy link
Member

iteles commented Jan 6, 2022

Perfect 👌

@nelsonic nelsonic added the priority-3 Third priority. Considered "Nice to Have". Not urgent. label Jan 6, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Jan 6, 2022

Label created: https://github.com/dwyl/labels/labels?page=2&sort=name-asc
image

Will add PR shortly.

@nelsonic
Copy link
Member Author

nelsonic commented Jan 6, 2022

@iteles you probably missed this notification: #100 📥
Please review/merge when you can so that we don't have merge-conflicts. 🙏

nelsonic added a commit that referenced this issue Jan 6, 2022
nelsonic added a commit that referenced this issue Jan 6, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Jan 6, 2022

@iteles once you've reviewed/merged Simon's PR #100 please see mine: #102 🙏

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Jan 6, 2022
iteles added a commit that referenced this issue Jan 26, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2022

PR merged. ✅ (Thanks @iteles!)

@nelsonic nelsonic closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality priority-3 Third priority. Considered "Nice to Have". Not urgent.
Projects
None yet
Development

No branches or pull requests

2 participants