Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest [email protected] #36

Merged
merged 8 commits into from
Nov 26, 2018
Merged

Update to latest [email protected] #36

merged 8 commits into from
Nov 26, 2018

Conversation

nelsonic
Copy link
Member

fixes #35

@codecov
Copy link

codecov bot commented Nov 26, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9776c64). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #36   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?     49           
  Branches          ?     11           
=======================================
  Hits              ?     49           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9776c64...c219ea0. Read the comment docs.

@nelsonic nelsonic requested a review from iteles November 26, 2018 21:48
iteles
iteles approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for doing this chore @nelsonic

@nelsonic
Copy link
Member Author

CI failing because of package-lock.json incongruity ...
https://travis-ci.org/dwyl/terminate/jobs/459971285#L442
image

🙄

@nelsonic
Copy link
Member Author

Works on localhost:
image

@nelsonic
Copy link
Member Author

I don't "miss" Node.js ... 😞
image
Why would the tests pass for one version of node and fail for another? 😠

@iteles iteles merged commit 2f5a9d4 into master Nov 26, 2018
@iteles iteles deleted the update-ps-tree-to-1.1.1-for-issue#35 branch November 26, 2018 22:09
@xiaoyuhen xiaoyuhen mentioned this pull request Nov 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ps-tree package may be unsafe now. Better find an alternative.
2 participants
@nelsonic @iteles