support branched package dependency

[zhebinliu]

Checklist

All items have to be completed before a PR is merged

• Adhere to Contribution Guidelines
• Updates to Decision Records considered?
• Updates to documentation at DX@Scale Guide considered?
• Tested changes?
• Unit Tests new and existing passing locally?

[reviewpad]

AI-Generated Summary: This pull request adds support for branched package dependencies in the package dependency resolution process. It includes updates to PackageDependencyResolver.ts to handle package dependencies with specified branches, changes to Package2VersionFetcher.ts to fetch branched packages by their branch and name, and modifications to BuildImpl.ts to resolve the dependencies of completed packages with specified branches. Additionally, a new private function splitString is added to BuildImpl.ts to help extract relevant information from dependency-package strings. Overall, these changes enable fetching and resolving branched package dependencies based on their specified branch information.

[reviewpad]

Reviewpad Report

‼️ Errors

• Unconventional commit detected: 'support branched package dependency' (7e4f5e2)
• Unconventional commit detected: 'merge from main' (0f7d710)
• Unconventional commit detected: 'Merge branch 'main' of https://github.com/dxatscale/sfpowerscripts into feat/package-branch-dependency' (1ee80f4)
• Unconventional commit detected: 'Merge branch 'main' into feat/package-branch-dependency' (939231d)
• Unconventional commit detected: 'Merge branch 'main' of https://github.com/dxatscale/sfpowerscripts into feat/package-branch-dependency' (cbeff04)
• Unconventional commit detected: 'Merge branch 'main' into feat/package-branch-dependency' (9011901)
• Unconventional commit detected: 'Add test for branched dependency resolver' (6a3426f)
• Unconventional commit detected: 'Merge branch 'feat/package-branch-dependency' of https://github.com/dxatscale/sfpowerscripts into feat/package-branch-dependency' (982734b)
• Unconventional commit detected: 'add test for package dependency resolver`' (59490d3)
• Unconventional commit detected: 'add branch to project schema' (27932a3)
• Unconventional commit detected: 'Merge branch 'main' into feat/package-branch-dependency' (c20c713)
• Unconventional title detected: 'support branched package dependency' illegal 'u' character in commit message type: col=01

⚠️ Warnings

• Please link an issue to the pull request

[reviewpad]

AI-Generated Summary: This pull request introduces changes to PackageDependencyResolver.ts, Package2VersionFetcher.ts, and BuildImpl.ts. The main updates include the addition of a branch option for package dependencies, improved logging, and code refactoring. The logic for handling branched packages has also been updated in the BuildImpl.ts file.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.56 🎉

Comparison is base (151d67c) 46.46% compared to head (e8ac182) 47.02%.

❗ Current head e8ac182 differs from pull request most recent head c20c713. Consider uploading reports for the commit c20c713 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
+ Coverage   46.46%   47.02%   +0.56%     
==========================================
  Files          70       70              
  Lines        3065     3094      +29     
  Branches      651      659       +8     
==========================================
+ Hits         1424     1455      +31     
+ Misses       1616     1614       -2     
  Partials       25       25              

Impacted Files	Coverage Δ
.../package/dependencies/PackageDependencyResolver.ts	96.11% <100.00%> (+3.01%)	⬆️
...core/src/package/version/Package2VersionFetcher.ts	86.04% <100.00%> (+6.04%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.