Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(install): Specify testLevel for a not optimized source package validating #1434

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

nabondance
Copy link
Contributor

@nabondance nabondance commented Nov 1, 2023

Fix #1417 using solution number 3
It was the solution with the smallest amount of code needed
Tested locally and working for the use case
Fell free to adapt and modify if needed

reviewpad:summary

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f07ff4) 46.86% compared to head (cba36d2) 46.86%.

❗ Current head cba36d2 differs from pull request most recent head 75e2424. Consider uploading reports for the commit 75e2424 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      302      302           
=======================================
  Hits         1249     1249           
  Misses       1414     1414           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabondance I think this is all good, its the cheapest one. Thanks!

Copy link

reviewpad bot commented Nov 8, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Merge branch 'main' into issue1417' (6228916)
  • Unconventional commit detected: 'Merge branch 'main' into issue1417' (75e2424)

⚠️ Warnings

  • Please rebase your pull request on the latest changes

@azlam-abdulsalam azlam-abdulsalam merged commit 00d7b64 into dxatscale:main Nov 13, 2023
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate do not run test for source package
2 participants