Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.9: push image with correct tag [BAC-2929] #15

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

eyqs
Copy link
Contributor

@eyqs eyqs commented Aug 8, 2022

After upgrading Docker from version 17.09.0-ce to version 20.10.14, we now have to explicitly tell Docker which tag should be pushed, otherwise it defaults to latest and can't find the image:

Successfully built 27d6f71b56f8
Successfully tagged *********:v781
+ docker tag *********:v781 dydxprotocol/*********:v781
+ docker login -u *********** -p ************************************
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
+ docker push dydxprotocol/*********
Using default tag: latest
The push refers to repository [docker.io/dydxprotocol/*********]
tag does not exist: dydxprotocol/*********:latest

I re-ran the job with SSH using this change and it passed:

64a0cf73263d:~/build# docker push dydxprotocol/$SERVICE_NAME
Using default tag: latest
The push refers to repository [docker.io/dydxprotocol/stacks]
tag does not exist: dydxprotocol/stacks:latest
64a0cf73263d:~/build# docker push dydxprotocol/$SERVICE_NAME:v$version
The push refers to repository [docker.io/dydxprotocol/stacks]
4960979fa4fe: Pushed 
93308e05734e: Pushed 
...

After upgrading Docker from version 17.09.0-ce to version 20.10.14, we now have to explicitly tell Docker which tag should be pushed, otherwise it defaults to `latest` and can't find the image:

```
Successfully built 27d6f71b56f8
Successfully tagged *********:v781
+ docker tag *********:v781 dydxprotocol/*********:v781
+ docker login -u *********** -p ************************************
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
+ docker push dydxprotocol/*********
Using default tag: latest
The push refers to repository [docker.io/dydxprotocol/*********]
tag does not exist: dydxprotocol/*********:latest
```
@linear
Copy link

linear bot commented Aug 8, 2022

BAC-2929 Update Alpine Linux

Previously, we were using node:12.18.3-alpine, which included Node 12.18.3 and Alpine Linux 3.11. Alpine Linux 3.11 has a number of critical vulnerabilities and exposures and security support ended in November 2021.

This PR upgrades us to use node:12.22.12-alpine3.15, which includes Node 12.22.12 and Alpine Linux 3.15. Node 12.22 is the earliest minor version of Node 12 that is available with Alpine Linux 3.15, and Alpine Linux 3.15 has no known vulnerabilities as of July 2022. Security support will continue for Alpine Linux 3.15 until November 2023.

The major changes between Node 12.18.3 and Node 12.22.12 are available in the CHANGELOG:

@eyqs eyqs changed the title push image with correct tag [BAC-2929] v0.2.9: push image with correct tag [BAC-2929] Aug 8, 2022
@eyqs eyqs merged commit da7d043 into master Aug 9, 2022
@eyqs eyqs deleted the eyqs/version branch August 9, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants