[BAC-943] v1.0.0: Build staging branch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioJuliano
commented
Feb 26, 2021
| # Push to ECR | ||
| $(aws ecr get-login --no-include-email --region us-east-1) | ||
| docker tag $SERVICE_NAME:v$version $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/$SERVICE_NAME:v$version | ||
| docker push $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/$SERVICE_NAME:v$version | ||
|
|
There was a problem hiding this comment.
Not a huge deal but this will make us not have to wait on dockerhub to have our services be deployable
AntonioJuliano
commented
Feb 26, 2021
| @@ -6,11 +6,6 @@ if [ "$CIRCLE_JOB" == "" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # Install AWS cli | |||
There was a problem hiding this comment.
These are already installed in our base docker container: https://github.com/dydxprotocol/docker-node/blob/master/Dockerfile#L3
lucas-dydx
reviewed
Feb 26, 2021
| set -euxo pipefail | ||
|
|
||
| if [ "$CIRCLE_JOB" == "" ]; then | ||
| echo "version-and-build.sh should only be run in circle" |
There was a problem hiding this comment.
small nit: Assuming you meant version-and-build-staging.sh?
Kenadia
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish to the docker repositories a container for the staging branch. Will need to update cookbook to make these versions deployable. And then update each service's circleci config so run this script on the staging branch.
Note: there is a separate version file and version numbering for staging. I think this is necessary as commits can be merged independently to master and staging but we'll have to have engineers adjust to it (not the same version numbers for prod and staging anymore)
Publish as breaking change as VERSION_STAGE needs to be added now
Also I think we should upgrade it to X.0.0 over 0.X.0