Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix GPU driver detection bug with bumblebee-managed dual video cards #1131

Closed
wants to merge 2 commits into from

Conversation

xudong-yang
Copy link

@xudong-yang xudong-yang commented Dec 6, 2018

Description

gpu_driver is enabled in my console to reassure the video card I am currently using, as my laptop is equipped with dual graphic cards.

However, the output seems a bit curious:

bug_screenshot

The cause is explained in the picture below:

cause

As I have used bumblebee to manage my graphic cards, normally the nvidia card is disabled. Simply add 2 to the NR where the nvidia card appears causes this incorrect result.

Features

Fix the bug described above.

Issues

I am sorry I did not come up with a simple solution to keep this line less than 100 characters. The line I altered has 117 characters now.

I do have some ideas to shorten it, like tmp_str="first half"; str="$tmp_str && the rest", but I think that is even worse.

To pass the travis check, the field name match is set as containing "nel driv" instead of exactly matching " Kernel driver in use" (as the line length should be smaller than 102 according to the .travis.yml).

This could be potentially problematic, but I think the keywords I choose should avoid much. Please Let me know if you you have any thoughts about this. You are also welcome to edit it directly if you like. Thanks!

TODO

No further work is required so far.

@konimex
Copy link
Contributor

konimex commented Dec 26, 2018

Since I don't know the impact of this commit to Intel+AMD GPUs and I can't test it at the moment, I'm going to wait for Dylan for this commit.

@dylanaraps
Copy link
Owner

This works for me on an intel machine.

Not sure about AMD or AMD+Intel or NVIDIA.

@xudong-yang
Copy link
Author

Yea it's probably better to ensure it's okay for AMD cards. Although I think it will not cause problems on AMD machines, I don't have any devices to test it. I noticed neofetch has a discord channel. Is anybody there using AMD?

@dylanaraps
Copy link
Owner

I'll ask around.

hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Aug 12, 2022
…with bumblebee-managed dual video cards

Upstream PR: dylanaraps#1131
Thanks to @xudong-yang

Co-authored-by: xudong-yang <[email protected]>
@hykilpikonna
Copy link

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

@xudong-yang xudong-yang deleted the master branch August 12, 2022 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants