Add Android support 2 #322

dylanaraps · 2016-08-27T23:05:07Z

This PR is the same as the last one, it just has all of the new changes from master (350~ Commits). A lot of the bugs from the previous PR should be fixed now and I'd love it if you guys could help me test it out. I've only got one Android device in my house and I'd like to make sure it works for as many people as possible.

Known bugs:

Ascii art padding is broken with ascii art that uses the unicode block char. (Android, Manjaro).
- Cause: Android devices don't seem to have any locale related envars set(?) so neofetch is using LANG=C which incorrectly calculates the padding when unicode block chars are involved.
- Solution: Assume block char is 3 chars wide when calculating padding.
./neofetch doesn't work.
- Workaround: bash ./neofetch
- env doesn't exist on android.
Fixed missing CPU name. @konimex
Broken uptime output.
Added model output. @konimex

Old PR: #240

dylanaraps · 2016-08-28T02:10:01Z

To fix the CPU speed issue in the previous PR I need to know the output of this command on multiple devices:

ls /sys/devices/system/cpu/cpu0/cpufreq/

konimex · 2016-08-28T03:46:27Z

You should consider adding Busybox as a dependency for Android, as (interesting in my case) awk doesn't exist in default Android.

This is the output without Busybox (and the files in cpufreq).

This is the output after Busybox (with --test).

dylanaraps · 2016-08-29T00:53:55Z

Will do, thanks for testing.

dylanaraps · 2016-08-29T02:21:48Z

@konimex, can you send me the output of cat /proc/cpuinfo on your device?

konimex · 2016-08-29T02:40:05Z

This is the result:
`processor : 0
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 1
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 2
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 3
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 4
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 5
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 6
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1

processor : 7
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd03
CPU revision : 1`

dylanaraps · 2016-08-29T03:34:26Z

It looks like we'll have to find another way to get the CPU name on Andoid since it isn't in /proc/cpuinfo

dylanaraps · 2016-08-29T04:11:36Z

Output from my friend's phone:

Uptime is broken
We should set shell_path to on on android

Included: - Added model support for Android - Changed CPU command to use native Android ones

Added and changed some Android commands

Fixed Android uptime

dylanaraps · 2016-10-18T21:56:55Z

I recently discovered termux which is an open source terminal emulator/linux environment for android.

Website: https://termux.com/
Source code: https://github.com/termux

#322 should work relatively bug free on Termux. My current thoughts are to officially support a single environment on Android (Termux) and either list Termux as a dependency or recommend it in the readme.

There are too many environments on android and due to the nature of neofetch (looking for files, commands etc) it'll be impossible to support them all.

Note: Termux also doesn't require a rooted phone to function.

What are your thoughts on this?

Edit: Termux requires android 5.0 and above, which may be an issue.
- See: termux/termux-app#6

Edit2: There is terminal IDE for older devices.

konimex · 2016-10-19T01:02:47Z

Actually, I don't think Termux is needed at all (well, for non-rooted devices, Termux is a comfortable solution since it has built-in Busybox environment so no hassle). Android has begun trying to get its shit together since 6.0 but Toybox hasn't caught up with Busybox yet, so Busybox is needed.

But since Termux's built in ps is much saner than Android's, I think just a dependency on Busybox will be fine, and add that it is recommended to install Termux since it has Busybox and a good ps built-in.

dylanaraps · 2016-10-19T01:10:02Z

Sounds good.

I'll fix the merge conflicts and reopen this PR with the latest changes from master. Then we can test the current status of this PR and fix any other bugs that come up.

dylanaraps · 2016-10-19T09:57:09Z

Fixed all merge conflicts and rebased with master.

Please test the branch now.

konimex · 2016-10-19T15:10:05Z

Looks good enough.

dylanaraps · 2016-10-19T21:26:07Z

I'm assuming that ./neofetch still doesn't work?

Can you also try with neofetch --config off --test?

konimex · 2016-10-19T22:11:43Z

Yep, ./neofetch doesn't work. Could this be related with the shebang on the first line since Android doesn't have /usr/bin/env ?

This is the second command (+ --disable publicip)

dylanaraps · 2016-10-20T02:21:21Z

This looks bug free!

I'll test some more at home and probably merge this later today.

Could this be related with the shebang on the first line since Android doesn't have /usr/bin/env ?

Yup

Thanks!

dylanaraps

Reminders

dylanaraps · 2016-10-20T06:17:52Z

neofetch

@@ -452,6 +465,8 @@ getpackages() {
            packages="$(pkg list | wc -l)"
        ;;
    esac
+
+    [ "$packages" == 0 ] && unset packages


We may not need this.

dylanaraps · 2016-10-20T06:18:37Z

neofetch

@@ -1717,8 +1736,8 @@ getbattery() {
                    *) index="$battery_num" ;;
                esac

-                batteries=("$(cat /sys/class/power_supply/BAT$battery_num/capacity)")
-                battery_state=("$(cat /sys/class/power_supply/BAT${battery_num}/status)")
+                batteries=($(cat /sys/class/power_supply/battery/capacity /sys/class/power_supply/BAT${battery_num}/capacity))


This would be better as a distro case statement.

dylanaraps · 2016-10-20T06:19:05Z

neofetch

-    while IFS='\n' read -r line 2>/dev/null; do
-        [ ${#line} -gt "$ascii_length" ] && ascii_length=${#line}
-        lines=$((lines+=1))
+    while IFS='' read -r line 2>/dev/null; do


This ovewrites some bug fixes

dylanaraps · 2016-10-20T09:33:39Z

I pushed some fixes, can you test again with neofetch --config off --test?

konimex · 2016-10-20T09:43:09Z

dylanaraps · 2016-10-20T10:07:40Z

👍

dylanaraps · 2016-10-21T08:02:33Z

The block chars in the ascii logo break the output in Material Terminal and Terminal Emulator for Android. Other logos render just fine, any ideas?

konimex · 2016-10-21T09:35:37Z

The block characters probably isn't ASCII so the render broke.

dylanaraps · 2016-10-21T10:41:16Z

Yeah, the only solution is to create new ascii art that uses regular characters. I've attempted it and none of my attempts look as nice as this blocky art.

dylanaraps · 2016-10-26T22:30:13Z

Merging this now.

Thanks again for testing.

dylanaraps added 2 commits August 28, 2016 08:59

Add ascii art and distro detection

71f0575

Add previous PR

12ba2f9

dylanaraps added the Enhancement label Aug 27, 2016

dylanaraps added 4 commits August 28, 2016 10:49

Fix padding on Android

5444ecd

Fix padding on android

76cc33f

Fix CPU name on android

bd7ebdf

Better uptime command that will work accross uptime versions

0a2fa2b

dylanaraps and others added 6 commits August 29, 2016 14:22

Fix new issues

26de54e

Added and changed some Android commands

7889c09

Included: - Added model support for Android - Changed CPU command to use native Android ones

Changed case

b3dcfe8

Merge pull request #324 from konimex/android2

f3a9074

Added and changed some Android commands

Fixed Android uptime

444c860

Merge pull request #325 from konimex/android2

3ee96ef

Fixed Android uptime

dylanaraps added the Help Wanted label Oct 2, 2016

merge master

0e87355

dylanaraps added the Needs Testing label Oct 19, 2016

dylanaraps commented Oct 20, 2016

View reviewed changes

Fix bugs

7a661b3

dylanaraps added 9 commits October 21, 2016 09:15

Fix bugs

7862e3a

Fix terminal output on android

e5359dc

Fix bug with block chars

7bdf5f1

Fix C locale padding issues

b13da1d

Don't do any dynamic prompt stuff in image off mode

6e47608

merge master

5f4e9e5

New android logo

edb6920

revert new logo

5df16a3

revert old logo

7b62b80

dylanaraps added 8 commits October 22, 2016 01:39

Merge master

bb01418

Merge branch 'master' into android2

76772fe

Fix cursor bugs if ascii art is taller than info

0b5d25d

Merge branch 'master' into android2

8bc6b2d

Merge branch 'master' into android2

d1ef3ab

Merge branch 'master' into android2

fd95783

Fix cursor artifcats in termux

ad3a902

Merge master

e8e859b

dylanaraps merged commit 51354b2 into master Oct 26, 2016

dylanaraps deleted the android2 branch October 26, 2016 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Android support 2 #322

Add Android support 2 #322

dylanaraps commented Aug 27, 2016 •

edited

Loading

dylanaraps commented Aug 28, 2016 •

edited

Loading

konimex commented Aug 28, 2016 •

edited

Loading

dylanaraps commented Aug 29, 2016

dylanaraps commented Aug 29, 2016 •

edited

Loading

konimex commented Aug 29, 2016

dylanaraps commented Aug 29, 2016

dylanaraps commented Aug 29, 2016 •

edited

Loading

dylanaraps commented Oct 18, 2016 •

edited

Loading

konimex commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

konimex commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

konimex commented Oct 19, 2016

dylanaraps commented Oct 20, 2016

dylanaraps left a comment

dylanaraps Oct 20, 2016

dylanaraps Oct 20, 2016

dylanaraps Oct 20, 2016

dylanaraps commented Oct 20, 2016

konimex commented Oct 20, 2016

dylanaraps commented Oct 20, 2016

dylanaraps commented Oct 21, 2016 •

edited

Loading

konimex commented Oct 21, 2016

dylanaraps commented Oct 21, 2016

dylanaraps commented Oct 26, 2016 •

edited

Loading

Add Android support 2 #322

Add Android support 2 #322

Conversation

dylanaraps commented Aug 27, 2016 • edited Loading

dylanaraps commented Aug 28, 2016 • edited Loading

konimex commented Aug 28, 2016 • edited Loading

dylanaraps commented Aug 29, 2016

dylanaraps commented Aug 29, 2016 • edited Loading

konimex commented Aug 29, 2016

dylanaraps commented Aug 29, 2016

dylanaraps commented Aug 29, 2016 • edited Loading

dylanaraps commented Oct 18, 2016 • edited Loading

konimex commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

konimex commented Oct 19, 2016

dylanaraps commented Oct 19, 2016

konimex commented Oct 19, 2016

dylanaraps commented Oct 20, 2016

dylanaraps left a comment

Choose a reason for hiding this comment

dylanaraps Oct 20, 2016

Choose a reason for hiding this comment

dylanaraps Oct 20, 2016

Choose a reason for hiding this comment

dylanaraps Oct 20, 2016

Choose a reason for hiding this comment

dylanaraps commented Oct 20, 2016

konimex commented Oct 20, 2016

dylanaraps commented Oct 20, 2016

dylanaraps commented Oct 21, 2016 • edited Loading

konimex commented Oct 21, 2016

dylanaraps commented Oct 21, 2016

dylanaraps commented Oct 26, 2016 • edited Loading

dylanaraps commented Aug 27, 2016 •

edited

Loading

dylanaraps commented Aug 28, 2016 •

edited

Loading

konimex commented Aug 28, 2016 •

edited

Loading

dylanaraps commented Aug 29, 2016 •

edited

Loading

dylanaraps commented Aug 29, 2016 •

edited

Loading

dylanaraps commented Oct 18, 2016 •

edited

Loading

dylanaraps commented Oct 21, 2016 •

edited

Loading

dylanaraps commented Oct 26, 2016 •

edited

Loading