Remove unused feature #166
Conversation
| function removeUnused(currentState) { | ||
| const dependenciesToRemove = currentState.get('unusedDependencies'); | ||
| if (skipAutoRemove(currentState) || _.isEmpty(dependenciesToRemove)) { | ||
| return new Promise(resolve => resolve(currentState)); |
There was a problem hiding this comment.
return Promise.resolve(currentState)
|
Nice, I'll review this properly when I get the time :) |
|
@LinusU thanks, I'm going to fix remarks after your full review :) |
|
Hi @LinusU, any updates on this? |
|
Please fix this conflicts in this branch so it can be merged. |
…ove_unused Fixed Conflicts: .gitignore
|
@amilajack ok, I've fixed it. |
|
After commenting that, I found out that this project doesn't have very comprehensive testing support. Have you tested this locally? Reluctant to merge until we have some kind of e2e test so we don't break the module. |
|
Thanks for this. Does this allow removing unused from |
|
@amilajack I also did not found any auto tests for this project, but I ran it locally on my several projects. So on my local environment it works well and doesn't affect any other functionality of @MaffooBristol no, it doesn't allow you to remove unused dependencies via |
|
@sholokhov actually I get quite a bit of false positives for unused imports - I would rather have a section in |
Hi!
Recently I opened issue #165 about automatically removing unused dependencies via special option. After some code exploration I didn't find this feature but I think that it will be quite convenient for end users. So I decided to add it into code base.