Windows compatibility: replace ifaces crate with get_if_addrs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice patch, I always wanted to replace the |
|
Doesn't change the public API either, neat. |
|
I'll push a new minor version to crates.io when I've come back from grocery shopping |
|
Ping 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Windows compatibility. The
ifacescrate is replaced with theget_if_addrscrate, which supplies the required functionality and is cross platform.UDP socket creation is moved to an os-specific function. There should likely be a macOS specialization as well, but I do not own a mac to test on. Reference: deprecrated/net2-rs#46