Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not abuse PathBuf::push("") for appending directory separator #4

Closed
wants to merge 1 commit into from
Closed

Do not abuse PathBuf::push("") for appending directory separator #4

wants to merge 1 commit into from

Commits on Oct 8, 2021

  1. Do not abuse PathBuf::push("") for appending directory separator 

    Since rust-lang/rust#89270 rust's pathbuf
push() normalizes the path if it is a verbatim path, so that the result
is still a valid verbatim path. This involves parsing reconstructing the
path.

Appending a path separator using push("") will no longer work, and if
it did, it would be very inefficient.

rust-lang/rust#89658

Signed-off-by: Sean Young <[email protected]>
    @seanyoung
    seanyoung committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ad5555a View commit details
    Browse the repository at this point in the history