-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rollapp): change finalization end blocker logic to not leave broken invariants #669
Conversation
…ionxyz/dymension into omritoptix/657-invariant-handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 30.62% 30.69% +0.06%
==========================================
Files 227 227
Lines 32024 32052 +28
==========================================
+ Hits 9807 9837 +30
+ Misses 20656 20653 -3
- Partials 1561 1562 +1 ☔ View full report in Codecov by Sentry. |
for _, stateInfoIndex := range blockHeightToFinalizationQueue.FinalizationQueue { | ||
stateInfo, found := k.GetStateInfo(ctx, stateInfoIndex.RollappId, stateInfoIndex.Index) | ||
if !found || stateInfo.Status != common.Status_PENDING { | ||
ctx.Logger().Error("Missing stateInfo data when trying to finalize or alreay finalized", "rollappID", stateInfoIndex.RollappId, "height", ctx.BlockHeight(), "index", stateInfoIndex.Index) | ||
continue | ||
// Invariant breaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Invariant breaking as later packets of same rollapp might be finalized
…ionxyz/dymension into omritoptix/657-invariant-handling
pls fix linter
|
…ionxyz/dymension into omritoptix/657-invariant-handling
…ionxyz/dymension into omritoptix/657-invariant-handling
Description
Closes #657
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: