feat(sequencer): Implement new create sequencer design #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zale144
changed the base branch from
main
to
zale144/978-new-create-rollapp-design
…-new-create-sequencer-design
…-new-create-sequencer-design
…-new-create-sequencer-design
…-update-rollapp-information
…9-new-create-sequencer-design
4 tasks
mtsitrin
reviewed
Jul 21, 2024
…-new-create-sequencer-design
…-design' into zale144/979-new-create-sequencer-design
danwt
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Ditto some of what I said here #980 (review)
Especially wrt. proto
x/rollapp/keeper/rollapp.go
Outdated
Comment on lines
34
to
37
| if !registrationFee.IsZero() { | ||
| if err := k.bankKeeper.SendCoinsFromAccountToModule(ctx, creator, types.ModuleName, registrationFee); err != nil { | ||
| return errorsmod.Wrap(types.ErrFeePayment, err.Error()) | ||
| } |
There was a problem hiding this comment.
seems like a bug fix for other pr?
Comment on lines
+35
to
+37
| if rollapp.Frozen { | ||
| return nil, types.ErrRollappJailed | ||
| } |
There was a problem hiding this comment.
we should remove ErrRollappJailed jailed imo because it's not well defined
Comment on lines
+19
to
+32
| metadata := SequencerMetadata{ | ||
| Moniker: d2.Moniker, | ||
| Details: d2.Details, | ||
| P2PSeeds: d2.P2PSeeds, | ||
| Rpcs: d2.Rpcs, | ||
| EvmRpcs: d2.EvmRpcs, | ||
| RestApiUrl: d2.RestApiUrl, | ||
| ExplorerUrl: d2.ExplorerUrl, | ||
| GenesisUrls: d2.GenesisUrls, | ||
| ContactDetails: d2.ContactDetails, | ||
| ExtraData: d2.ExtraData, | ||
| Snapshots: d2.Snapshots, | ||
| GasPrice: d2.GasPrice, | ||
| } |
There was a problem hiding this comment.
so you cant update p2p or rpc or evm or rest api or explorer or genesis or snapshots or gas price?
mtsitrin
reviewed
Jul 23, 2024
| // snapshots of the sequencer | ||
| repeated SnapshotInfo snapshots = 11; | ||
| // gas_price defines the value for each gas unit | ||
| string gas_price = 12 [(gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Int"]; |
There was a problem hiding this comment.
@omritoptix I think this unneeded.
Better way is to have known gas price is to put it on-chain
There was a problem hiding this comment.
this is for UX only I believe
…-new-create-sequencer-design
…-new-create-sequencer-design
…-new-create-sequencer-design
danwt
reviewed
Jul 25, 2024
Comment on lines
+179
to
+191
| P2PSeeds: nil, // TODO | ||
| Rpcs: nil, // TODO | ||
| EvmRpcs: nil, // TODO | ||
| RestApiUrl: "", // TODO | ||
| ExplorerUrl: "", // TODO | ||
| GenesisUrls: []string{}, // TODO | ||
| ContactDetails: &sequencertypes.ContactDetails{ // TODO | ||
| Website: "", // TODO | ||
| Telegram: "", // TODO | ||
| X: "", // TODO | ||
| }, // TODO | ||
| ExtraData: nil, // TODO | ||
| Snapshots: []*sequencertypes.SnapshotInfo{}, // TODO |
Comment on lines
+26
to
+28
| if sequencer.Jailed { | ||
| return nil, types.ErrSequencerJailed | ||
| } |
Comment on lines
+12
to
+13
| // details define other optional details. | ||
| string details = 2; |
danwt
approved these changes
Jul 25, 2024
…tration, update tests
zale144
merged commit 0d734ac
into
zale144/978-new-create-rollapp-design
10 of 116 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #979
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
----;
For Reviewer:
---;
After reviewer approval: