Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX properly return preset categories on locator #241

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

muskie9
Copy link
Member

@muskie9 muskie9 commented Jun 13, 2023

resolves #240

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: -1.41 ⚠️

Comparison is base (8629c58) 43.85% compared to head (3cd21f5) 42.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##                  4     #241      +/-   ##
============================================
- Coverage     43.85%   42.44%   -1.41%     
- Complexity      167      171       +4     
============================================
  Files            13       13              
  Lines           618      523      -95     
============================================
- Hits            271      222      -49     
+ Misses          347      301      -46     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Page/LocatorController.php 51.03% <80.00%> (+1.72%) ⬆️
src/Page/Locator.php 88.73% <100.00%> (-0.56%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muskie9 muskie9 merged commit 6229e98 into dynamic:4 Jun 15, 2023
@muskie9 muskie9 deleted the pull/usedCategories branch June 15, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG getUsedCategories() does not inform the pre-filtered categories properly
1 participant