Filmgrain - fix memory leak when blur = 0 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaromil
approved these changes
May 30, 2024
|
to trigger a minor release at least one commit should start with 4 chars |
|
Okay, thanks, I will do that in the future. Let me look it over a bit today and see if there's anything else I want to fix, then I'll let you know and I'll be done for a while and you can merge it. |
|
Did some more fixes. I think I'm finally good, so if it looks good to you too please go ahead and send it. Thanks! |
on Windows RAND_MAX is only 32,767.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the framebuffer allocation to the f0r_update function (so it should be thread safe now) and I swapped out my clamp function for the one in frei0r._math.h even though I doubt there's that much performance difference with that.