Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM Decoding] FCVT 'type' field cannot equal 'opc' field #254

Closed
nathanhjay opened this issue Nov 16, 2016 · 1 comment
Closed

[ARM Decoding] FCVT 'type' field cannot equal 'opc' field #254

nathanhjay opened this issue Nov 16, 2016 · 1 comment
Assignees
@ssunny7
Labels
bug
Milestone
ARM decoding cleanup

Comments

@nathanhjay
Copy link
Contributor

This instruction should be invalid.

Bytes: 9a c3 62 1e
Output: fcvt d26, d28
ssunny7 added a commit that referenced this issue Dec 20, 2016
@ssunny7
Issue #253 (Floating point instructions can have mismatched operand s…
5cc151b 
…izes)

For all instructions except FCVT, a 'type' field value greater than 1 should render the instruction invalid. The 'opc' field is used only for FCVT to determine only the destination register. All other instructions and operands use solely the 'type' field to determine source/destination registers.

This commit also fixes Issue #254.
@ssunny7
Copy link
Contributor

ssunny7 commented Dec 20, 2016

Fixed by 5cc151b.

@wrwilliams wrwilliams added the bug label Feb 9, 2017
@wrwilliams wrwilliams modified the milestone: ARM decoding cleanup Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssunny7 ssunny7

Labels
bug
Projects
None yet
Milestone
ARM decoding cleanup
Development

No branches or pull requests
3 participants
@wrwilliams @nathanhjay @ssunny7