Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use system header <> syntax for dyninst includes #518

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

stanfordcox
Copy link
Contributor

Fedora installs dyninst includes into /usr/include/dyninst; thus any file included from within another dyninst include will not be found if the

syntax is used since that syntax only searches system includes and /usr/include/dyninst is not a standard system include. Using "HEADER" syntax (search same containing directory solves the problem. There are only two cases of this so I'm guess it was an accident as opposed to an intentional decision.

@stanfordcox
Copy link
Contributor Author

I see this failure
CMake Error at examples/CMakeLists.txt:14 (add_dependencies):
The dependency target "dynDwarf" of target "codeCoverage" does not exist.
CMake Error at examples/CMakeLists.txt:14 (add_dependencies):
The dependency target "dynElf" of target "codeCoverage" does not exist.

perhaps CMakeLists.txt needs:

if (UNIX)
set (DEPS ${DEPS} dynDwarf dynElf)
endif()

@mxz297 mxz297 merged commit fbc3c86 into dyninst:master Jan 15, 2019
@stanfordcox stanfordcox deleted the scox/includes branch April 20, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants