✨ Add report_url param to CloudForCustomers.extract_records()
#1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymzet
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Added feedback. Pls also use standard naming convention for PR title (see https://github.com/dyvenia/viadot/blob/2.0/CONTRIBUTING.md#commit-messages-style).
Rafalz13
changed the title
report_url argumentreport_url argument to extract_records function in C4C
trymzet
approved these changes
Oct 4, 2024
trymzet
changed the title
report_url argument to extract_records function in C4Creport_url argument to CloudForCustomers.extract_records()
trymzet
changed the title
report_url argument to CloudForCustomers.extract_records()report_url param to CloudForCustomers.extract_records()
trymzet
approved these changes
Oct 4, 2024
trymzet
force-pushed
the
c4c_credentials_issue
branch
from
718d085
to
7826b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added report_url argument.
Importance
Deployments are not working without this argument
Checklist
This PR:
CONTRIBUTING.mdCHANGELOG.md