✨ Introduce ip_addresses datasource #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for this nice mr! I notice that you also parse the tenant attribute of the ip addresses. Can you add a test for this functionality? Just to make sure that the attached tenants are flattened correctly! Else LGTM! |
|
Sure, I will update the PR and a testcase of this. |
twink0r
force-pushed
the
implement_ip_addresses_datasource
branch
from
bcc7467
to
63c1c94
Compare
|
Is it possible to release a version that contains this data source ? |
|
Yes, I want to merge #158 as well. |
|
Is there documentation missing? Can't find the datasource on https://registry.terraform.io/providers/e-breuninger/netbox/1.6.3/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.