Enable group, role, or tenant to be used in VLAN query #287
+119
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbreckle
reviewed
Nov 3, 2022
fbreckle
reviewed
Nov 4, 2022
tstarck
force-pushed
the
data-vlan
branch
2 times, most recently
from
7e1b812
to
9d18d2c
Compare
fbreckle
reviewed
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only name and VID could be used to filter responses for
netbox_vlandata source. This PR allows to filter VLANs by VLAN group, IPAM role, or tenant.There isn't yet a resource for creating VLAN groups, and thus there's a lack of test coverage for that attribute.