Remove IP Prefix description if it is null #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your PR! |
I'll try! I'm not very familiar with tests in Go, but I'll certainly take a look and update this PR when I've had time. |
This will set the description to a single space (`" "`) if the description is passed in as `null`. Previously, a null description was not updating the description in the NetBox API call, and so the resource was showing an expected change on every plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue whereby removing the description of an IP Prefix had no effect when applied.
This will set the description to a single space (
" ") if the description is passed in asnull. Setting the description to an empty string also does not appear to clear the description, so this uses the same pattern as in the IP Address resource type.