Change the geojson export code to use confirmed trips instead of clea… #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned trips The changes were actually fairly minor - add new `get_confirmed_timeline` and `get_confirmed_timeline_from_dt` which reads cleaned places but confirmed trips - fortunately, the timeline linkage code focuses on trips, so it works with confirmed trips instead of cleaned trips - change the code which looks up the sections and stops to use the cleaned_trip id instead of the trip id if it is a confirmed trip TODO: change this if/when we have confirmed sections. We now get back a geojson with the inferred label fields. This completes the server changes outlined in e-mission/e-mission-docs#674 (comment)
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Oct 7, 2021
Simplify the retrieval code by:
- pulling out duplicated code from the original call and the local fallback
into a separate function (`readTripsAndUnprocessedInputs`)
- pulling out the processing of the trips and the manual input handling for
future unification with the labeling code
- in the common case, only read inputs *after* the pipeline is complete.
Due to e-mission/e-mission-server#837, the geojson
trips should also now have any prior user inputs included in the trip.
This plugs a huge performance issue for longitudinal data collection, because
otherwise, we were reading the entire list of user inputs from the
beginning of the install, which grows unboundedly.
with this change, we will only read inputs from the timeline run point to
now, which is bounded, and should be short depending on how frequently the
timeline runs.
This addresses:
e-mission/e-mission-docs#674 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ned trips
The changes were actually fairly minor
get_confirmed_timelineandget_confirmed_timeline_from_dtwhichreads cleaned places but confirmed trips
confirmed trips instead of cleaned trips
id instead of the trip id if it is a confirmed trip
TODO: change this if/when we have confirmed sections.
We now get back a geojson with the inferred label fields.
This completes the server changes outlined in
e-mission/e-mission-docs#674 (comment)