Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort confirmation modal flow if attached form is invalid #2253

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Abort confirmation modal flow if attached form is invalid #2253

merged 3 commits into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. Abort confirmation modal flow if attached form is invalid 

    Otherwise, the modal would just close without anything happening.
    @niklasmohrin
    niklasmohrin committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c7ec39b View commit details
    Browse the repository at this point in the history

  2. rm evap/evaluation/templates/confirmation_text_modal.html

    @niklasmohrin
    niklasmohrin committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8271ed5 View commit details
    Browse the repository at this point in the history

  3. Replace existing usage of slot="submit-group"

    @niklasmohrin
    niklasmohrin committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3b4c1e2 View commit details
    Browse the repository at this point in the history