Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon-yellow to icon-blue #2276

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

janno42
Copy link
Member

@janno42 janno42 commented Sep 5, 2024

The filter buttons could get a complete overhaul in the future, this is a quick fix upon individual manager request.

Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I′m blue da ba dee da ba di

Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought that we would be able to query for a theming preference from the browser (like with light / dark theme), but it seems there is no such feature. I found this discussion which gives some insight: https://discourse.wicg.io/t/user-set-media-types-e-g-to-detect-color-blind-users/946/

Anyways, good change!

@janno42 janno42 merged commit ead8ffd into e-valuation:main Sep 9, 2024
12 checks passed
@janno42 janno42 deleted the ui_colors branch September 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants