Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to store objectives and constraints as optimizationProblem properties #648

Closed

Conversation

tobiasbecher
Copy link

No description provided.

Objectives and constraints are now stored as variables of the optimization problem. This takes away a lot of the redundant operations in the optimization function that loop over the cst otherwise.
Also changed the objective function to now calculate all objective function values in a separate function and then sum them up afterwards.
First changes for Pareto optimization were also added with the normalization options
@tobiasbecher tobiasbecher changed the title Dev pareto obj Update to store objectives and constraints as optimizationProblem properties (Still under construction) Jul 25, 2023
Readded function head to getConstraintBounds and more documentation.
Copy link
Author

@tobiasbecher tobiasbecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes related to normalization of objectives, that are not relevant for this part, but for the sandwich algorithms. Let me know, if I should move that to a seperate pull request

@tobiasbecher tobiasbecher marked this pull request as ready for review August 1, 2023 08:44
@wahln wahln changed the title Update to store objectives and constraints as optimizationProblem properties (Still under construction) Update to store objectives and constraints as optimizationProblem properties Sep 1, 2023
Copy link
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I am still not convinced that everything is done given the state of a few files.
Another comment: if we have an objectiveFunctions file that stores objective values as array, why do we not have a objectiveJacobian?

@tobiasbecher
Copy link
Author

Closed due to changes being added in other pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants