Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in TOPAS engine with dij calculation #760

Closed

Conversation

remocristoforetti
Copy link

strjoint requires a string not a char array. This is a possible fix, I only tested in one specific case, but it's a small fix.

@wahln
Copy link
Contributor

wahln commented Aug 30, 2024

Can you explain the issue?

A problem of this proposed fix is that "string" does not exist in Octave. We need to work with char arrays.

@remocristoforetti
Copy link
Author

Ah I see, the error is triggered by strjoin at line 2078. Possibly the char array imageName is not accepted as a valid input.
Avoiding the use of strjoin seams to work as well

@wahln
Copy link
Contributor

wahln commented Aug 30, 2024

But strjoin({'test','test2'},';') works without issues on cell arrays of chars, so I still don't get it.

@wahln
Copy link
Contributor

wahln commented Aug 30, 2024

Ah I guess that imageName already is a joined char array, so we don't need strjoin.

@wahln wahln closed this Aug 30, 2024
@remocristoforetti remocristoforetti deleted the dev_topasEngineBugFix branch August 30, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants