Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #2165

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update setup.py #2165

merged 1 commit into from
Nov 8, 2023

Conversation

rbolgaryn
Copy link
Member

@rbolgaryn rbolgaryn commented Nov 8, 2023

pip install igraph is incorrect, we should use pip install python-igraphinstead

:code:`pip install igraph` is incorrect, we should use :code:`pip install python-igraph`instead
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3544151) 79.58% compared to head (dfa5972) 79.55%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2165      +/-   ##
===========================================
- Coverage    79.58%   79.55%   -0.04%     
===========================================
  Files          255      255              
  Lines        27789    27798       +9     
===========================================
- Hits         22117    22115       -2     
- Misses        5672     5683      +11     
Files Coverage Δ
...ter_classes/transformers/powerTransformersCim16.py 99.40% <100.00%> (+<0.01%) ⬆️
pandapower/converter/cim/cim2pp/from_cim.py 82.85% <ø> (ø)
setup.py 0.00% <ø> (ø)
pandapower/converter/cim/cim2pp/build_pp_net.py 70.62% <31.25%> (-5.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbolgaryn rbolgaryn merged commit d8e128e into develop Nov 8, 2023
17 of 19 checks passed
@rbolgaryn rbolgaryn deleted the fix/igraph_dependency branch November 8, 2023 11:23
@szhorvat
Copy link

szhorvat commented Nov 8, 2023

pip install igraph is incorrect, we should use pip install python-igraphinstead

@rbolgaryn @mrifraunhofer This is has not been true for over two years now. Please revert to pip install igraph. Using python-igraph is deprecated and was was originally intended to be shut down already a year ago, as you can see at https://pypi.org/project/python-igraph/

See igraph/python-igraph#699

The name "python-igraph" will be discontinued as soon as enough projects stop depending on it.

@rbolgaryn
Copy link
Member Author

Dear @szhorvat ,

thank you very much for pointing it out!

We will revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants