Fix test disk clean #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiwei-ebay
pushed a commit
that referenced
this pull request
Mar 4, 2024
* fix testDiskClean * fix testDiskClean Co-authored-by: zhewenf2 <[email protected]>
caiwei-ebay
pushed a commit
that referenced
this pull request
Mar 4, 2024
* fix testDiskClean * fix testDiskClean Co-authored-by: zhewenf2 <[email protected]>
caiwei-ebay
pushed a commit
that referenced
this pull request
Mar 4, 2024
* fix testDiskClean * fix testDiskClean Co-authored-by: zhewenf2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Fix test
TestDiskCleanWhich issue(s) this PR fixes:
Fixes an issue that causes flaky tests. The current test may lead to the txt file not being created since the file is empty. So I wrote some content into the txt file before it was scanned into the list. In this case, the txt file would always be created before it was scanned.