New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set-pageSize behaviour #455

Merged

eKoopmans merged 2 commits into master from fix/set-page-size

Jul 10, 2021

Owner

eKoopmans commented Jul 10, 2021

This PR;

fixes a bug where set({ pageSize }) was directly setting this.prop.pageSize, rather than using this.setPageSize as intended
adds a test to catch the bug

eKoopmans added 2 commits

July 9, 2021 17:29


          Add unit test for broken pageSize setter

e8dc1ac


          Reorder settings check to capture pageSize

6e03bb6

eKoopmans merged commit e2bcb98 into master

eKoopmans deleted the fix/set-page-size branch

July 10, 2021 03:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet