Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery Server TSAN fixes [16106] #3070

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Discovery Server TSAN fixes [16106] #3070

merged 8 commits into from
Dec 13, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Nov 7, 2022 •
edited
Loading

Signed-off-by: jparisu [email protected]

Description

This PR is meant to palliate issues using Discovery Server related with TSAN.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Fast DDS test suite has been run locally.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu jparisu marked this pull request as ready for review November 7, 2022 11:14
@jparisu jparisu marked this pull request as draft November 7, 2022 11:23
@jparisu jparisu force-pushed the fix/tsan-ds branch 3 times, most recently from ad16dde to ed3a896 Compare November 10, 2022 06:42
@jparisu jparisu marked this pull request as ready for review November 14, 2022 11:11
juanlofer-eprosima
juanlofer-eprosima previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link

EduPonz commented Nov 28, 2022

@richiprosima please test this

@EduPonz EduPonz added this to the v2.9.0 milestone Dec 7, 2022
remove include mutex
f0c910e 
Signed-off-by: jparisu <[email protected]>
uncrustify
942596e 
Signed-off-by: jparisu <[email protected]>
@jsan-rt
Copy link
Contributor

jsan-rt commented Dec 7, 2022

@richiprosima please test this

@jsan-rt
Copy link
Contributor

jsan-rt commented Dec 7, 2022

@richiprosima please test linux

@jsan-rt jsan-rt added the ci-pending PR which CI is running label Dec 9, 2022
@EduPonz
Copy link

EduPonz commented Dec 10, 2022

@richiprosima please test this

@MiguelCompany
Copy link
Member

MiguelCompany commented Dec 12, 2022 •
edited
Loading

CI for 2.9.0-rc:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Discovery server Build Status

@MiguelCompany MiguelCompany merged commit 5686f36 into master Dec 13, 2022
@MiguelCompany MiguelCompany deleted the fix/tsan-ds branch December 13, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima left review comments

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jparisu @EduPonz @jsan-rt @MiguelCompany @juanlofer-eprosima