Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests failing with subprocess aborted error [16199] #3094

Merged
merged 9 commits into from
Nov 23, 2022
Merged

Fix tests failing with subprocess aborted error [16199] #3094

merged 9 commits into from
Nov 23, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Nov 15, 2022 •
edited
Loading

This PR intends to fix the failing tests issued at compiling Fast DDS with statistics module enabled.

The test not covered by this PR, and so they continue failing are:

  • PubSub layer (deprecated):
    • BlackboxTests_FastRTPS.PubSubHistory.ReliableTransientLocalKeepLast1Data300Kb.Transport (Timeout)
  • Statistics (needs some re-design):
    • BlackboxTests_DDS_PIM.PubSubBasic.ReceivedPropertiesDataWithinSizeLimit.Transport (Failed)
    • BlackboxTests_DDS_PIM.PubSubBasic.ReceivedPropertiesDataWithinSizeLimit.Intraprocess (Failed)
    • BlackboxTests_DDS_PIM.PubSubBasic.ReceivedPropertiesDataWithinSizeLimit.Datasharing (Failed)
    • UDPv4Tests.send_to_wrong_interface (Subprocess aborted)
    • UDPv6Tests.send_to_wrong_interface (Subprocess aborted)
  • Others:
    • BlackboxTests_FastRTPS.TransportTCP.TCP_TLS.Transport (Timeout)
    • BlackboxTests_DDS_PIM.TransportTCP.TCP_TLS.Transport (Timeout)
  • Flaky tests:
    • BlackboxTests_DDS_PIM.DDSDiscovery.AddDiscoveryServerToList (Failed)

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 force-pushed the hotfix/subprocess-aborted branch 2 times, most recently from 6c510d2 to 66b1b69 Compare November 16, 2022 06:47
@rsanchez15
Copy link
Contributor Author

@richiprosima please test this

@rsanchez15 rsanchez15 changed the title [WIP] Fix tests failing with subprocess aborted error [16199] Fix tests failing with subprocess aborted error [16199] Nov 17, 2022
@rsanchez15
Copy link
Contributor Author

@richiprosima please test this

@rsanchez15
Copy link
Contributor Author

@richiprosima please test this

jparisu
jparisu suggested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the following test, that did not fail before.
If it is flaky, it should be labeled as so.

845 | BlackboxTests_DDS_PIM.DDSStatus.IncompatibleQosConditions.Datasharing

test/unittest/dds/topic/DDSSQLFilter/DDSSQLFilterTests.cpp Show resolved Hide resolved
jparisu
jparisu approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit e9f1357 into master Nov 23, 2022
@EduPonz EduPonz deleted the hotfix/subprocess-aborted branch November 23, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparisu jparisu jparisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @jparisu @EduPonz