Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16440] Update Fast CDR submodule to v1.0.26 #3143

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[16440] Update Fast CDR submodule to v1.0.26 #3143

merged 1 commit into from
Dec 13, 2022

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Dec 12, 2022 •
edited by jsan-rt
Loading

Signed-off-by: Eduardo Ponz [email protected]

Description

This PR updates the Fast CDR submodule to v1.0.26

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Fast DDS test suite has been run locally.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: Documentation builds and tests pass locally.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added the skip-ci Automatically pass CI label Dec 12, 2022
@EduPonz EduPonz added this to the v2.9.0 milestone Dec 12, 2022
@EduPonz EduPonz marked this pull request as ready for review December 12, 2022 11:19
jsan-rt
jsan-rt approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit bc2b6c4 into master Dec 13, 2022
@EduPonz EduPonz deleted the feature/update-fastcdr-submodule branch December 13, 2022 06:11
@MiguelBarro MiguelBarro mentioned this pull request Dec 13, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @jsan-rt