Fix remote locators filtering when whitelist provided #3933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #3733 introduced a regression in which remote locators were being wrongly discarded when a whitelist is provided. In particular, the PR replaced several calls to
transform_remote_locator
(which for a remote locator performs no transformation and always return true irrespective of whether a whitelist is provided) byis_locator_allowed
(which discards remote locators when a whitelist is provided).This PR fixes the issue by checking if a locator is remote before going through the
is_locator_allowed
filter (every place wheretransform_remote_locator
->is_locator_allowed
change was introduced).Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist