Log warning upon receiver resource creation failure (backport #3924, backport #3954) #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 77a85dd)
9 tasks
MiguelCompany
previously approved these changes
Oct 17, 2023
|
@richiprosima Please test mac |
|
I am closing this PR because in a future PR, this log message is going to be managed as a warning instead of as an error. |
* Refs #19773. Turn log error into a log warning. Signed-off-by: Miguel Company <[email protected]> * Refs #19773. Add boolean argument to `createReceiverResources`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
changed the title
MiguelCompany
approved these changes
Oct 25, 2023
fujitatomoya
approved these changes
Oct 25, 2023
|
@richiprosima Please test mac |
|
Mac failure is not related to this PR and known to happen in this specific branch. |
JLBuenoLopez
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an automatic backport of pull request #3924 done by Mergify.
We have also added the backport of #3954