Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19728] Update README CI badges with last completed build (avoid 'running' case) #3968

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[19728] Update README CI badges with last completed build (avoid 'running' case) #3968

merged 1 commit into from
Oct 30, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 27, 2023 •
edited by EduPonz
Loading

Description

Including the lastCompletedBuild/ statement in the badge, the README displays the jenkins last completed build and avoid the running badge.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Oct 27, 2023
@JesusPoderoso JesusPoderoso added this to the v2.12.1 milestone Oct 27, 2023
@JesusPoderoso JesusPoderoso self-assigned this Oct 27, 2023
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Oct 30, 2023
@EduPonz EduPonz merged commit 467216b into master Oct 30, 2023
10 checks passed
@EduPonz EduPonz deleted the hotfix/improve_jenkins_labels branch October 30, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz