Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19354] Add XML parser bit_bound bounds check #3975

Merged
merged 4 commits into from
Nov 3, 2023
Merged

[19354] Add XML parser bit_bound bounds check #3975

merged 4 commits into from
Nov 3, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 31, 2023 •
edited by MiguelCompany
Loading

Description

Bit mask's bit bound attribute can be set to values out of expected bounds (0 < bit_bound < 65) through XML configuration. This PR add a check in XML parser to avoid it.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.12.1 milestone Oct 31, 2023
@JesusPoderoso JesusPoderoso self-assigned this Oct 31, 2023
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test mac please test windows

@JesusPoderoso
Refs #19354: Check empty name
35d0dfe 
Signed-off-by: JesusPoderoso <[email protected]>
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Nov 3, 2023
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test mac

@MiguelCompany MiguelCompany merged commit e318c5b into master Nov 3, 2023
9 of 14 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/check_bitmask_bitbound branch November 3, 2023 21:45
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 3, 2023
@JesusPoderoso @mergify
Add XML parser bit_bound bounds check (#3975)
761c213 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)
@mergify mergify bot mentioned this pull request Nov 3, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 3, 2023
@JesusPoderoso @mergify
Add XML parser bit_bound bounds check (#3975)
5aa43cd 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)
mergify bot pushed a commit that referenced this pull request Nov 3, 2023
@JesusPoderoso @mergify
Add XML parser bit_bound bounds check (#3975)
82dc45c 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)
This was referenced Nov 3, 2023
Merged
Merged
EduPonz pushed a commit that referenced this pull request Nov 13, 2023
@mergify @JesusPoderoso
Add XML parser bit_bound bounds check (#3975) (#3989)
12bb5b3 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)

Co-authored-by: Jesús Poderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Nov 13, 2023
@mergify @JesusPoderoso
Add XML parser bit_bound bounds check (#3975) (#3990)
3a0f5fd 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)

Co-authored-by: Jesús Poderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Nov 13, 2023
@mergify @JesusPoderoso
Add XML parser bit_bound bounds check (#3975) (#3991)
8d0b35a 
* Refs #19354: Add XML parser bit_bound bounds check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Add regression test

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Check empty name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19354: Apply rev suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit e318c5b)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @MiguelCompany