-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19839] Fix flow controllers utests compilation when using Fast CDR from thirdparty #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CDR from thirdparty Signed-off-by: EduPonz <[email protected]>
richiware
requested changes
Oct 31, 2023
Signed-off-by: EduPonz <[email protected]>
richiware
approved these changes
Nov 2, 2023
@Mergifyio backport 2.11.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
…dparty (#3979) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
…dparty (#3979) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
…dparty (#3979) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c)
EduPonz
added a commit
that referenced
this pull request
Nov 13, 2023
…dparty (#3979) (#3984) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Nov 13, 2023
…dparty (#3979) (#3985) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Nov 13, 2023
…dparty (#3979) (#3986) * Refs #19839: Fix flow controllers utests compilation when using Fast CDR from thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19839: Apply Ricardo's suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit a2e699c) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Flow controllers unit test end up including
<fastcdr/cdr/fixed_size_string.hpp>
through the internal headersrc/cpp/statistics/types/types.h
, but they do not link with Fast CDR. In a colcon context this is OK as Fast CDR will always be compiled and installed before compiling Fast DDS, so its header are in the include path when compiling the unit tests. However, when using the Fast CDR submodule, CMake may start by compiling the unit tests prior to Fast CDR and Fast DDS, and in that case the Fast CDR headers are not in the include path. This PR fixes this by explicitly linking with Fast CDR in those tests.@Mergifyio backport 2.11.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist